Skip to content

Don't exit with an error if there are no changes to submodules #105217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2022
Merged

Don't exit with an error if there are no changes to submodules #105217

merged 1 commit into from
Dec 4, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 3, 2022

Fixes #105215, which regressed in #104865.

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2022
@jyn514
Copy link
Member Author

jyn514 commented Dec 3, 2022

@bors p=1 this breaks all fresh clones

@bjorn3
Copy link
Member

bjorn3 commented Dec 3, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2022

📌 Commit a0e5615 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2022
@bors
Copy link
Collaborator

bors commented Dec 4, 2022

⌛ Testing commit a0e5615 with merge 2a39e45...

@bors
Copy link
Collaborator

bors commented Dec 4, 2022

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 2a39e45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2022
@bors bors merged commit 2a39e45 into rust-lang:master Dec 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 4, 2022
@jyn514 jyn514 deleted the submodule-fixes branch December 4, 2022 04:17
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2a39e45): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [1.8%, 4.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105217 - jyn514:submodule-fixes, r=bjorn3
dc8fdee 
Don't exit with an error if there are no changes to submodules

Fixes rust-lang#105215, which regressed in rust-lang#104865.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Need to run x.py setup multiple times for it to create a config.toml
6 participants
@jyn514 @rustbot @bjorn3 @bors @rust-timer @Mark-Simulacrum